search

ceph / ceph-csi

CSI driver for Ceph
Apache License 2.0
1.19k stars 527 forks source link

helm: add cli argument instanceid #4666

Open zerotens opened 3 weeks ago

zerotens commented 3 weeks ago

Describe what this PR does

This PR adds the existing cli argument --instanceid as an configurable helm value instanceID. This allows configuring the instance id parameter of Ceph CSI without manually changing the deployment or helm chart.

Is there anything that requires special attention

Is the change backward compatible?

Yes

Are there concerns around backward compatibility?

No, the default values in code have not been changed but are now overrideable via helm and cli arguments.

Checklist:

Show available bot commands These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR: * `/retest ci/centos/`: retest the `` after unrelated failure (please report the failure too!)
zerotens commented 2 weeks ago

Please take a look. There's a lint failure https://github.com/ceph/ceph-csi/actions/runs/9388846826/job/25883583707?pr=4666

a new live is required in both values.yaml

The new line at the end of the files values.yaml should be added now.

Rakshith-R commented 2 weeks ago

Can you please mention the new config in docs https://github.com/ceph/ceph-csi/tree/devel/charts/ceph-csi-rbd#configuration similar for cephfs Sorry for not noticing this earlier.

Please also add a point in PendingReleaseNotes. https://github.com/ceph/ceph-csi/blob/devel/PendingReleaseNotes.md

Madhu-1 commented 1 week ago

@zerotens can you please check CI failures?

Rakshith-R commented 1 day ago

@mergifyio queue

mergify[bot] commented 1 day ago

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.