rbd: cleanup inconsistent state in `reserveSnap()` after a failure

ceph / ceph-csi

CSI driver for Ceph

Apache License 2.0

1.29k stars 549 forks source link

rbd: cleanup inconsistent state in `reserveSnap()` after a failure #4946

Closed nixpanic closed 2 weeks ago

nixpanic commented 2 weeks ago

reserveSnap() can potentially fail halfway through, in that case it needs to undo the snapshot reservation and restore modified attributes of the snapshot.

Fixes: #4945

nixpanic commented 2 weeks ago

@Madhu-1 @Rakshith-R , any other concerns?

Rakshith-R commented 2 weeks ago

@Madhu-1 @Rakshith-R , any other concerns?

LGTM.

nixpanic commented 2 weeks ago

@mergifyio rebase

mergify[bot] commented 2 weeks ago

rebase

☑️ Nothing to do

- [ ] any of: - [ ] `#commits > 1` [📌 rebase requirement] - [ ] `#commits-behind > 0` [📌 rebase requirement] - [ ] `-linear-history` [📌 rebase requirement] - [X] `-closed` [📌 rebase requirement] - [X] `-conflict` [📌 rebase requirement] - [X] `queue-position = -1` [📌 rebase requirement]

nixpanic commented 2 weeks ago

@mergifyio queue

mergify[bot] commented 2 weeks ago

queue