search

ceph / ceph-iscsi-cli

NOTICE: moved to https://github.com/ceph/ceph-iscsi
GNU General Public License v3.0
25 stars 25 forks source link

Misc fixes #119

Closed mikechristie closed 6 years ago

mikechristie commented 6 years ago

Just some misc patches.

The only interesting patch may be: "Use ceph-iscsi-config valid_disk"

This patch requires the ceph-iscsi-config addition: https://github.com/ceph/ceph-iscsi-config/pull/76

dillaman commented 6 years ago

jenkins flake8

mikechristie commented 6 years ago

Patches have been rebased.

dillaman commented 6 years ago

@mikechristie See the flake8 errors

mikechristie commented 6 years ago

Ran tox locally and they are all fixed now.

I added one new patch:

https://github.com/ceph/ceph-iscsi-cli/pull/119/commits/e9f97110d9ef9df3523fa46dc2796b100c1d3a31

because for one of the ceph-iscsi-config tox changes I needed to move human_size to that package. The above patch then has us use the ceph-iscsi-config function.