search

ceph / ceph-iscsi-config

NOTICE: moved to https://github.com/ceph/ceph-iscsi
GNU General Public License v3.0
22 stars 28 forks source link

[RFC] ceph iscsi config: add max_data_area setting #31

Closed mikechristie closed 6 years ago

mikechristie commented 7 years ago

Allow users to config the tcmu data area ring size.

This reqiures a updated kernel with the patch:

https://www.spinics.net/lists/target-devel/msg16097.html

and a updated rtslib with this PR merged:

https://github.com/open-iscsi/rtslib-fb/pull/112

This is marked a RFC because we are still waiting on upstream testing/review, so the patch should not be merged yet.

mikechristie commented 7 years ago

Ok. Will fix.

dillaman commented 7 years ago

@mikechristie alternative PR #32

dillaman commented 7 years ago

lgtm -- pending rtslib_fb change

mikechristie commented 6 years ago

Dropping this PR. Following the idea here

https://github.com/open-iscsi/targetcli-fb/pull/95

where we do not want to update every tool/lib in the stack to add a setting, we can modify rtslib-fb and our tools/libs to take control settings after the initial object initialization but before enablement, and we can do the same for ceph-iscsi-config/gwcli.

Will make new PRs.