search

ceph / ceph-iscsi-config

NOTICE: moved to https://github.com/ceph/ceph-iscsi
GNU General Public License v3.0
22 stars 28 forks source link

build/ops: add COPYING file and add license/copyright notice to spec file #82

Closed smithfarm closed 5 years ago

smithfarm commented 5 years ago

@dillaman I'm making some changes to the spec file (and other miscellaneous stuff, like COPYING) in order to prepare a ceph-iscsi-config package for submission to openSUSE Factory.

I'd appreciate it if you could review. Also, would you like all the changes in this one single PR, or would you instead prefer separate PRs for each change?

smithfarm commented 5 years ago

@dillaman Also, I apologize in advance if you're not the right person to ping for review! In that case, could you suggest who would be a better person to review/merge it?

dillaman commented 5 years ago

@smithfarm Multiple PRs is fine w/ me

smithfarm commented 5 years ago

@dillaman Are you guys really attached to the in-spec changelog? In SUSE the changelog is maintained outside of the spec file - there is just an empty %changelog section to satisfy RPMLINT.

The problem, as I understand it, is that this embedded changelog tends to lead to the spec file becoming very large over time.

In the Ceph spec file, the %changelog contents were removed by https://github.com/ceph/ceph/commit/ec776f4b859613b3ba785cddf078140f583cc447 (in December 2011).

dillaman commented 5 years ago

@smithfarm The changelog is not really maintained so I'm not attached to it. Downstream, RH tools will automatically populate the changelog from any patches that are applied to the downstream release.

smithfarm commented 5 years ago

@dillaman Cool. I opened https://github.com/ceph/ceph-iscsi-config/pull/84.