search

ceph / ceph-iscsi

Ceph iSCSI tools
GNU General Public License v3.0
62 stars 59 forks source link

[rbd-target-api] Add Ubuntu to read_os_release dict #167

Open phvalguima opened 4 years ago

phvalguima commented 4 years ago

Environment: Ceph-iscsi from master branch Ubuntu 19.10 Using python3

When running Ubuntu, I get some of the requests failing with: {   "message": "MACHINE_NAME failed package validation checks - OS is unsupported" }

Looking into the code, I can see method read_os_release is called and Ubuntu is not on the list. Ubuntu 19.10 offers almost all base packages for ceph-iscsi installation using setup.py. Therefore, I would suggest minimum version to be 19.10.

mikechristie commented 4 years ago

Looking into the code, I can see method read_os_release is called and Ubuntu is not on the list. Ubuntu 19.10 offers almost all base packages for ceph-iscsi installation

What is it still missing? Should we make a note of what's missing in the README or add a warning message for the user somewhere to make it easier for them to figure it out?