ceph / ceph-medic

find common issues in ceph clusters
MIT License
22 stars 18 forks source link

TestLogSetup.test_create_log_config_correctly fails on RHEL 8's Python 3 #107

Closed ktdreyer closed 5 years ago

ktdreyer commented 5 years ago

I'm seeing the following test failure when packaging ceph-medic for RHEL 8:

+ py.test-3.6 -v ceph_medic/tests
============================= test session starts ==============================
platform linux -- Python 3.6.8, pytest-3.4.2, py-1.5.3, pluggy-0.6.0 -- /usr/libexec/platform-python
cachedir: .pytest_cache
rootdir: /builddir/build/BUILD/ceph-medic-1.0.4, inifile: setup.cfg
collecting ... collected 80 items

...
=================================== FAILURES ===================================
________________ TestLogSetup.test_create_log_config_correctly _________________

self = <ceph_medic.tests.test_log.TestLogSetup object at 0x7f0d963cd828>
tmpdir = local('/tmp/pytest-of-mockbuild/pytest-0/test_create_log_config_correct0')

    def test_create_log_config_correctly(self, tmpdir):
        tmp_log_path = str(tmpdir)
        location = os.path.join(tmp_log_path, 'ceph-medic.conf')
        with open(location, 'w') as _f:
            _f.write("""\n[global]\n--log-path=%s""" % tmp_log_path)
        config = configuration.load(location)
        log.setup(config)
        logger = logging.getLogger()
>       assert len(logger.handlers) == 1
E       assert 2 == 1
E        +  where 2 = len([<LogCaptureHandler (NOTSET)>, <FileHandler /tmp/pytest-of-mockbuild/pytest-0/test_create_log_config_correct0/ceph-medic-2019-04-22.log (DEBUG)>])
E        +    where [<LogCaptureHandler (NOTSET)>, <FileHandler /tmp/pytest-of-mockbuild/pytest-0/test_create_log_config_correct0/ceph-medic-2019-04-22.log (DEBUG)>] = <RootLogger root (DEBUG)>.handlers

ceph_medic/tests/test_log.py:31: AssertionError
===================== 1 failed, 79 passed in 0.26 seconds ======================
ktdreyer commented 5 years ago

Whoops, I should've mentioned this was using 1.0.4 from PyPI. I see I should be using master.

ktdreyer commented 5 years ago

Ok the suite passes with master.