search

ceph / ceph-rust

Rust-lang interface to Ceph.
Apache License 2.0
98 stars 43 forks source link

fix compilation error due to Rust/C type mismatches #5

Closed pgerber closed 7 years ago

pgerber commented 7 years ago

Most errors where found when compiling on armv7-unknown-linux-gnueabihf but there may be more type mismatches, I haven't thoroughly checked.

• change i8 to c_char for pointers to CString (c_char is unsigned on some architectures) • change i64 to t_time where it represents a timestamp (t_time is 32 bit on on 32 Architectures, at least on Linux) • change a few other types to the correct C type

cholcombe973 commented 7 years ago

Hey thanks for this! I haven't had a chance to compile this on armv7. Great work

cholcombe973 commented 7 years ago

@hanscj1 could you do a release? I don't think I have access to release to this package on crates.io. I bumped the version a minor version but maybe it should be a major since we're changing types in this which will break clients potentially.

hanscj1 commented 7 years ago

Sure enough.

hanscj1 commented 7 years ago

done

cholcombe973 commented 7 years ago

Sweet! Thanks. Thank you also Peter :)

On Tue, Mar 7, 2017 at 3:56 PM, Chris Jones notifications@github.com wrote:

done

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ceph/ceph-rust/pull/5#issuecomment-284900308, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6qE63tXqAjoclw7_br8zUNU6nTjTmwks5rje6RgaJpZM4MWK6_ .