search

ceph / ceph-rust

Rust-lang interface to Ceph.
Apache License 2.0
96 stars 43 forks source link

Change example over to safe code calls #6

Closed cholcombe973 closed 7 years ago

cholcombe973 commented 7 years ago

I'm doing a little preflight check before the tech talk next week.

I modified the example a little and just swapped out the unsafe for safe calls. I caught a problem with the rados_fsid parsing function. I'm not sure how I missed that before. I must've forgotten to test it. I tested it against a ceph jewel cluster running on ec2 and noticed ceph is returning a hyphenated uuid string not just a simple uuid string like I had thought. I also noticed an intermittent failure with the ceph_mon_command_with_data function. I don't know yet what is triggering it. I can run it several times in a row and it's fine and then the next one will panic.

cholcombe973 commented 7 years ago

So that leaves just a small call left that's unsafe. Maybe we can write the safe wrapper in the tech talk :)

cholcombe973 commented 7 years ago

Thanks!

On Fri, Mar 17, 2017 at 3:52 PM, Chris Jones notifications@github.com wrote:

Merged #6 https://github.com/ceph/ceph-rust/pull/6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ceph/ceph-rust/pull/6#event-1005266233, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6qE-gu3Mmm_SciQYVqsNsKyPomi0mCks5rmw6egaJpZM4MhIPr .