search

ceph / chacra

A binary/file REST API to aid in multi-distro|arch|release management
9 stars 18 forks source link

ansible: reload nginx after renewing cert #221

Closed djgalloway closed 7 years ago

djgalloway commented 7 years ago

The nginx service must be reloaded when the renewed certificate is put in place.

Additionally, letsencrypt will only renew the certificate if it's due to expire in <= 30 days. Attempting to renew roughly every 15 days is plenty.

Signed-off-by: David Galloway dgallowa@redhat.com

dmick commented 7 years ago

I don't understand the check build failure, but it also seems like the check build hasn't run in a long time (about a zillion commits in it) ?

andrewschoen commented 7 years ago

jenkins test this please

andrewschoen commented 7 years ago

@dmick the build failure there is because it's trying to install a version of postgresql on a xenial node that's not available - I've manually modified the job to ensure we get a trusty node.

ktdreyer commented 7 years ago

probably want && there instead of ; ?

djgalloway commented 7 years ago

@ktdreyer I suppose that would've been better. letsencrypt exits with a 0 return code whether the cert gets renewed or not but I suppose we don't need to reload nginx if there's an error when attempting to renew.

https://github.com/ceph/chacra/pull/222