search

ceph / chacra

A binary/file REST API to aid in multi-distro|arch|release management
9 stars 18 forks source link

Revert "util,models/: include .ddeb when building deb repos" #272

Closed alfredodeza closed 3 years ago

alfredodeza commented 4 years ago

Reverts ceph/chacra#267

I don't think we are ready for this, and there was no agreement if using a forked binary was the right approach. Reverting for now until we get consensus.

alfredodeza commented 4 years ago

I don't think we are discarding, but temporarily reverting so that we get a healthy system, and can get to some agreement on how to move forward.

djgalloway commented 4 years ago

Well, we have a working system at the moment. Everything is functioning normally.. just with warnings.

Let's come to an agreement on how to move forward and get it done.

Does the special version just need to be compiled and make installed? Are we comfortable doing that with a repo we haven't vetted keeping in mind it touches all our binaries?

alfredodeza commented 4 years ago

Well, we have a working system at the moment. Everything is functioning normally.. just with warnings.

Let's come to an agreement on how to move forward and get it done.

Does the special version just need to be compiled and make installed?

It is more involved.

Are we comfortable doing that with a repo we haven't vetted keeping in mind it touches all our binaries?

We aren't, and there is no agreement yet. What happened is that we merged and then couldn't get an agreement on how to proceed and then promptly forgot about this (or at least I did forget). I propose we revert, and then try to get some consensus.

tchaikov commented 4 years ago

It is more involved.

@alfredodeza 2 months ago, i hoped i could get the blessings and/or support from us. and i noted the plan A and plan B at https://github.com/ceph/ceph-build/pull/1367#issuecomment-522393725 . after the discussion with you over IRC, i learned that you wanted to hold this back, and that we needed to wait for Ken.

alfredodeza commented 4 years ago

@tchaikov yeah I think waiting for @ktdreyer 's perspective is a good thing... lets get together to try and find some common ground!

ktdreyer commented 4 years ago

My concern with forking reprepro is that someone on our team will need to watch that fork closely over the years. Someone will need to make sure that security fixes in upstream reprepro will also go into the forked reprepro. Who is going to do that, and for how long?