search

ceph / chacra

A binary/file REST API to aid in multi-distro|arch|release management
9 stars 16 forks source link

controllers/repos: Create correct repo file for openSUSE/SLE #275

Closed toabctl closed 4 years ago

toabctl commented 4 years ago

On openSUSE/SLE, a repo file needs to be interpretable by zypper and the format is slightly different to the on for yum/dnf. So instead of creating multiple entries, just create a single one.

Fixes: https://tracker.ceph.com/issues/44183

Signed-off-by: Thomas Bechtold tbechtold@suse.com

smithfarm commented 4 years ago

However, Jenkins says the tests are failing:

chacra/tests/controllers/repos/test_repos.py::TestRepoApiController::test_repo_endpoint_deb[/repos/foobar/firefly/head/ubuntu/trusty/repo/] FAILED [ 79%]
chacra/tests/controllers/repos/test_repos.py::TestRepoApiController::test_repo_endpoint_deb[/repos/foobar/firefly/head/ubuntu/trusty/flavors/default/repo/] FAILED [ 80%]
chacra/tests/controllers/repos/test_repos.py::TestRepoApiController::test_repo_endpoint_rpm[/repos/foobar/firefly/head/centos/7/repo/] FAILED [ 80%]
chacra/tests/controllers/repos/test_repos.py::TestRepoApiController::test_repo_endpoint_rpm[/repos/foobar/firefly/head/centos/7/flavors/default/repo/] FAILED [ 80%]
chacra/tests/controllers/repos/test_repos.py::TestRepoApiController::test_repo_endpoint_rpm_opensuse_sle[/repos/foobar/firefly/head/opensuse/15.1/repo/] FAILED [ 80%]
chacra/tests/controllers/repos/test_repos.py::TestRepoApiController::test_repo_endpoint_rpm_opensuse_sle[/repos/foobar/firefly/head/opensuse/15.1/flavors/default/repo/] FAILED [ 81%]
smithfarm commented 4 years ago

@toabctl Sorry, I deleted the original tracker issue by mistake. The new one is https://tracker.ceph.com/issues/44204

Would you mind adjusting the commit message and PR body? (Sorry again....)

toabctl commented 4 years ago

Would you mind adjusting the commit message and PR body? (Sorry again....)

@smithfarm done

toabctl commented 4 years ago

@smithfarm tests improved and pass now. Imo ready for merging.

djgalloway commented 4 years ago

@toabctl this has been deployed