Add missing anticipation_timeout argument to PullPriorityQueue constructor

ceph / dmclock

Code that implements the dmclock distributed quality of service algorithm. See "mClock: Handling Throughput Variability for Hypervisor IO Scheduling" by Gulati, Merchant, and Varman.

Other

89 stars 55 forks source link

Add missing anticipation_timeout argument to PullPriorityQueue constructor #43

Closed TaewoongKim closed 7 years ago

TaewoongKim commented 7 years ago

I missed adding anticipation_timeout argument for a constructor at the previous PR.

If this PR is merged I will make a ceph PR that makes anticipation timeout be configurable for ceph.

The code will be https://github.com/TaewoongKim/ceph/commit/8f17269f534dfbf7acebd7fd5ad251df4592b2c8

ivancich commented 7 years ago

@TaewoongKim Is it OK if we don't pull this into ceph immediately? There's a bit of work to check everything and we just did a pull not that long ago, so when possible I like to accumulate commits before the pull. But please let me know if you have any timing constraints.

TaewoongKim commented 7 years ago

@ivancich OK, let me know if it's ready.