rbd: implement librbd.rbd_group_snap_get_info

ceph / go-ceph

Go bindings for Ceph :octopus: :octopus: :octopus:

MIT License

611 stars 251 forks source link

rbd: implement librbd.rbd_group_snap_get_info #1025

Open nixpanic opened 3 weeks ago

nixpanic commented 3 weeks ago

The new GroupSnapGetInfo function can be used to get a list of the RBD image snapshots that were created as part of the RBD group snapshot.

This feature is implemented in 2 steps:

direct librbd call (only in Ceph main branch)
modification to use dlsym

I hope that makes it easier to understand, and might help others contributing such dynamically loaded functions too.

Depends-on: ceph/ceph#59883 Depends-on: ceph/ceph#59959

Checklist

[x] Added tests for features and functional changes
[x] Public functions and types are documented
[x] Standard formatting is applied to Go code
[x] Is this a new API? Added a new file that begins with //go:build ceph_preview
[x] Ran make api-update to record new APIs

anoopcs9 commented 3 weeks ago

@Mergifyio rebase

mergify[bot] commented 3 weeks ago

rebase

✅ Branch has been successfully rebased

nixpanic commented 3 weeks ago

Thanks @anoopcs9!

It seems that @ajarr is planning to send a PR for librbd.h to uncomment the namespace_type in the struct. Until that is done, this PR should not get merged yet.

idryomov commented 2 weeks ago

send a PR for librbd.h to uncomment the namespace_type in the struct

https://github.com/ceph/ceph/pull/59883

dpulls[bot] commented 2 weeks ago

:warning: Dpulls not installed on repository ceph/ceph. Checkout our quickstart for how to install.

dpulls[bot] commented 1 week ago

:warning: Dpulls not installed on repository ceph/ceph. Checkout our quickstart for how to install.

dpulls[bot] commented 1 week ago

:warning: Dpulls not installed on repository ceph/ceph. Checkout our quickstart for how to install.

phlogistonjohn commented 1 week ago

@mergifyio rebase

mergify[bot] commented 1 week ago

rebase

✅ Branch has been successfully rebased

dpulls[bot] commented 1 week ago

:warning: Dpulls not installed on repository ceph/ceph. Checkout our quickstart for how to install.

dpulls[bot] commented 1 week ago

:warning: Dpulls not installed on repository ceph/ceph. Checkout our quickstart for how to install.

nixpanic commented 1 week ago

All dependencies are merged, this should be ready for review (again) now.

nixpanic commented 1 week ago

@mergifyio refresh

Maybe that is needed to detect the merging of the dependencies?

mergify[bot] commented 1 week ago

refresh

✅ Pull request refreshed

nixpanic commented 1 week ago

@mergifyio rebase

mergify[bot] commented 1 week ago

rebase

✅ Nothing to do for rebase action

nixpanic commented 1 day ago

@ansiwen could you please have a look at this?

nixpanic commented 20 hours ago

@mergifyio rebase

mergify[bot] commented 20 hours ago

rebase