ceph / merfi

Finds and signs files with different signing tools (gpg, rpm-sign)
MIT License
3 stars 3 forks source link

logger: handle bytes log messages #72

Closed ktdreyer closed 5 years ago

ktdreyer commented 5 years ago

In Python 3, the output from Popen is bytes, not str. This leads to a crash later on in our logger, because rstrip() does not work on bytes.

Transparently handle bytes messages in our logger by decoding them to strings.

alfredodeza commented 5 years ago

we might want to just use the logging module if problems related to logging keep coming up. Alternatively, we could start switching to python3-only