search

ceph / pulpito-ng

5 stars 7 forks source link

JobList: Hover on status col shows failure reason #38

Closed zmc closed 1 year ago

zmc commented 1 year ago

This truncates the longer strings to 200 chars.

render[bot] commented 1 year ago

Your Render PR Server URL is https://pulpito-ng-pr-38.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cj5upas5kgrc7381u5bg.

zmc commented 1 year ago

@kamoltat I chose an arbitrary 200-char limit to display before chopping the string, in order to avoid the tooltip from getting unreasonably large. Sounds like a larger number would be good - what do you think?

zmc commented 1 year ago

@yuriw I would love your feedback on this as well

zmc commented 1 year ago

@kamoltat ping

kamoltat commented 1 year ago

@zmc The longest I've seen is 701 characters long. I think we can try 750 or 800? if it doesn't look to ugly

kamoltat commented 1 year ago

tested with 800 char

image
zmc commented 1 year ago

@kamoltat Thanks - re-pushed with the 800 char limit.

netlify[bot] commented 1 year ago

Deploy Preview for pulpito ready!

Name Link
Latest commit 8892c9c8a6f59b06c1d499f5de4797fd673b3f8d
Latest deploy log https://app.netlify.com/sites/pulpito/deploys/64e6564b7763ef0008303ce4
Deploy Preview https://deploy-preview-38--pulpito.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.