ceph / pulpito

A dashboard for Ceph tests
23 stars 29 forks source link

run_jobs_table: add show description button #70

Closed kshtsk closed 4 years ago

kshtsk commented 4 years ago

Add 'Show Description' button which toggles run jobs table to show only following columns: 'Description', 'Duration', 'Links', 'Job ID', 'Status'.

This makes it easy to observe which tests are failed and makes it possilbe to quickly copy the description.

Signed-off-by: Kyr Shatskyy kyrylo.shatskyy@suse.com

badone commented 4 years ago

This seems to add a "phantom button" for me in firefox 75.

image

kshtsk commented 4 years ago

This seems to add a "phantom button" for me in firefox 75.

image

cleanup your cache

kshtsk commented 4 years ago

this is not new, the "Expand All" is shown as "phantom button" too until page loaded especially on low connection, and since "Show Description" button has the same logic as "Expand All" there can be two phantom buttons

badone commented 4 years ago

If it requires end user action you probably should have sent out an email about it.

kshtsk commented 4 years ago

If it requires end user action you probably should have sent out an email about it.

I had no idea about this issue, I didn't have such behavior on many browsers, sorry can not predict everything

kshtsk commented 4 years ago

but @badone not sure that I SHOULD, if you be so kind and send out an email about this, as soon as you faced this issue and could you please point out which else browsers do you have with this and steps of how to refresh cache for all possible users...

badone commented 4 years ago

@kshtsk Not exactly sure what you are asking but I'm pretty sure the answer is "No"

kshtsk commented 4 years ago

@kshtsk Not exactly sure what you are asking but I'm pretty sure the answer is "No"

@badone np, thanks though, just wondering if the issue went away for you, because I cannot reproduce it

badone commented 4 years ago

@kshtsk Yes, it went away so probably not worth spending any more cycles on.

yuriw commented 4 years ago

@kshtsk can we move the "Show Description" button to the right so it' snot confused with "Expand All"?

PS: Great feature BTW !

kshtsk commented 4 years ago

@yuriw did you mean to move it to the left of all buttons or between "Expand All" and group of Queued/Waiting/Running/Failed/Passed/Total buttons?