ceph / pulpito

A dashboard for Ceph tests
23 stars 29 forks source link

config.py.in: revert change breaking pulpito role #71

Closed kshtsk closed 4 years ago

kshtsk commented 4 years ago

Corresponding step of pulpito role task it is fixing: https://github.com/ceph/ceph-cm-ansible/blob/master/roles/pulpito/tasks/setup_pulpito.yml#L51-56

- name: Set paddles_address
  lineinfile:
    dest: "{{ pulpito_repo_path }}/prod.py"
    regexp: "^paddles_address = "
    line: "paddles_address = '{{ paddles_address|mandatory }}'"
  register: pulpito_config

Signed-off-by: Kyr Shatskyy kyrylo.shatskyy@suse.com

kshtsk commented 4 years ago

This is kinda revert, and might be strange, but probably the the pulpito role in ceph-cm-ansible can be rewritten. Use config files instead of patching py files?

kshtsk commented 4 years ago

Works for me (maybe add a comment to that with a link to the ansible role so we are aware of it?)

@toabctl What is this link about you think, or you mean another place where should I add?

Corresponding step of pulpito role task it is fixing: https://github.com/ceph/ceph-cm-ansible/blob/master/roles/pulpito/tasks/setup_pulpito.yml#L51-56

kshtsk commented 4 years ago

@toabctl check extra commit out.