search

ceph / pulpito

A dashboard for Ceph tests
23 stars 29 forks source link

switch to py3 #80

Closed kshtsk closed 3 years ago

djgalloway commented 3 years ago

I'll have to defer to @tchaikov or maybe @zmc on this. Every time I approve a python PR, it bites me.

kshtsk commented 3 years ago

thanks @djgalloway I hope it won't bite, since we merge the corresponding ceph/ceph-cm-ansible#603 will see what @tchaikov says, meanwhile can try and test this PR in sepia with prior run of the ceph-cm-ansible run?

kshtsk commented 3 years ago

Because the ceph-cm-ansbile depends on this PR I guess for pulpito because of py3, so we need both

kshtsk commented 3 years ago

LGTM. but, @kshtsk, how did you test this change? as the travis based test basically only builds, runs a docker image and checks if the image is up and running. so it does not imply that the change works with python3, IMHO.

I have tested it using manual run of teuthology-deploy pointing the pulpito, paddles, and ceph-cm-ansible repos/branches. It was including the running a suite, on openSUSE distro. For Ubuntu, I only tested pulpito and paddles are up and running.