search

ceph / romana

Other
51 stars 25 forks source link

vagrant precise package build is point to old director of calamari-clients instead of romana #3

Open ksingh7 opened 9 years ago

ksingh7 commented 9 years ago

Hi i noticed that after cloning romana git repository and trying to build packages for precise , salt is still trying to use old directory which is calamari clients , it should point and use romana instead.

==> default: Mounting shared folders...
    default: /git => /Users/ksingh/git
    default: /vagrant => /Users/ksingh/git/romana/vagrant/precise-build
    default: /srv/salt => /Users/ksingh/git/romana/vagrant/salt/roots
==> default: Running provisioner: salt...
Copying salt minion config to vm.
Checking if salt-minion is installed
[INFO    ] Running state [/git/calamari-clients] at time 21:12:17.163983
[INFO    ] Executing state git.latest for /git/calamari-clients
[INFO    ] Executing command "git clone /git/calamari-clients '/home/vagrant/clients' " as user 'vagrant' in directory '/home/vagrant'
[INFO    ] Executing command 'git rev-parse HEAD' as user 'vagrant' in directory '/home/vagrant/clients'
[INFO    ] Repository /git/calamari-clients cloned to /home/vagrant/clients
[INFO    ] {'new': '/git/calamari-clients', 'revision': '8bea195a87bb0c5e58bcbe93c3ee61576a0e9fcf'}
[INFO    ] Completed state [/git/calamari-clients] at time 21:12:18.316359
ChristinaMeno commented 9 years ago

@ksingh7 this is an annoying part of the build where we assume that the repo gets shared across from the host to the guest during vagrant.

A workaround tille this gets fixed would be to clone romana as git clone https://github.com/ceph/romana.git calamari-cilents

The code that needs fixing lives here: https://github.com/ceph/romana/blob/master/vagrant/precise-build/Vagrantfile#L16

Where we share it across we imply the name of the repository conventionally.

ksingh7 commented 9 years ago

@GregMeno Thanks for your reply , hope you would have received my proposal email , i sent few days back :)

Anyways , i tried cloning romana to calamari-clients directory and building precise packages , but it failed [ERROR ] stderr: fatal: No tags can describe '8bea195a87bb0c5e58bcbe93c3ee61576a0e9fcf'.

Below are the links to logs

Full build logs : http://paste.ubuntu.com/11737414/ Grep filtered logs : http://paste.ubuntu.com/11737421/ Grep Grep filtered logs: http://paste.ubuntu.com/11737424/

I also tried cloning the old calamari-clients repo and build pakages but that also fails on the same error [ERROR ] stderr: fatal: No tags can describe '8bea195a87bb0c5e58bcbe93c3ee61576a0e9fcf'.

Copying @dmick , hoping to get some help

AVVS commented 9 years ago

same thing here, trying to build debs, but not working with the same error

tserong commented 9 years ago

@ksingh7 can you please try building with https://github.com/ceph/romana/pull/4 applied, to see if that works any better for you?

ksingh7 commented 9 years ago

@tserong thanks a ton for fixing this , but due to busy schedule i might not able to test this.

@AVVS Could you try testing the fix posted by @tserong