search

ceph / teuthology-api

A REST API to execute teuthology commands.
MIT License
2 stars 10 forks source link

Delete GH_USER cookie #70

Open VallariAg opened 1 month ago

VallariAg commented 1 month ago

Even after we logout from pulpito-ng, the GH_USER cookie isn't deleted.

It would be nice to delete this before sending RedirectResponse in /logout endpoint on teuthology-api.

Example (chrome):

image
VallariAg commented 1 month ago

Instead of using cookies, we can instead use react's UseContext to call useSession hook in pulpito-ng and store user data in context. This is a better solution because cookies can have stale data but UseContext would have latest data from teuthology-api. And all components can use that data.

AyishikD commented 1 month ago

@VallariAg Can I solve this issue too?

VallariAg commented 1 month ago

@AyishikD I need to have a discussion with other members about the two approaches and confirm how to proceed. I will update here what we decide to do.

AyishikD commented 1 month ago

@AyishikD I need to have a discussion with other members about the two approaches and confirm how to proceed. I will update here what we decide to do.

Sure thank you