search

cequence-io / openai-scala-client

Scala client for OpenAI API
MIT License
191 stars 20 forks source link

Fixes use of functions with Assistant and adds an example. #73

Closed vega113 closed 4 months ago

vega113 commented 4 months ago
peterbanda commented 4 months ago

Hi @vega113 , thanks for submitting a PR. @bburdiliak pls. review

bburdiliak commented 4 months ago

Hey @vega113, thank you for the contribution.

try using asSafeJson instead of asSafe

vega113 commented 4 months ago

Ok, thanks. However I can't reproduce the issue. I pulled the updates from master and it still compiles locally. On Mon, Jul 8, 2024 at 11:55 AM Boris Burdiliak @.***> wrote:

Hey @vega113 https://github.com/vega113, thank you for the contribution.

try using asSafeJson instead of asSafe

— Reply to this email directly, view it on GitHub https://github.com/cequence-io/openai-scala-client/pull/73#issuecomment-2213428881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYLERFVIMECWIXLXSZUU3ZLJHYZAVCNFSM6AAAAABKCJ4U2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJTGQZDQOBYGE . You are receiving this because you were mentioned.Message ID: @.***>

bburdiliak commented 4 months ago

image

Thank you for putting effort into this.

I see the branch is behind master by 11 commits. Is the branch really updated?

vega113 commented 4 months ago

I pushed a fix, please check

On Tue, Jul 9, 2024 at 11:04 AM Boris Burdiliak @.***> wrote:

image.png (view on web) https://github.com/cequence-io/openai-scala-client/assets/521839/b04b4e0a-0c3e-4021-98e5-9e916f60fc27

Thank you for putting effort into this.

I see the branch is behind master by 11 commits. Is the branch really updated?

— Reply to this email directly, view it on GitHub https://github.com/cequence-io/openai-scala-client/pull/73#issuecomment-2216882178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYLERYJ5ACBN3PUQ2VG3LZLOKPTAVCNFSM6AAAAABKCJ4U2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWHA4DEMJXHA . You are receiving this because you were mentioned.Message ID: @.***>

peterbanda commented 4 months ago

@vega113 almost there :)

OpenAIServiceImpl.scala isn't formatted properly! OpenAIChatCompletionServiceImpl.scala isn't formatted properly! CreateRunWithFunctionCall.scala isn't formatted properly!

vega113 commented 4 months ago

Reformatted with scalafmt

On Wed, Jul 10, 2024 at 4:48 PM Peter Banda @.***> wrote:

@vega113 https://github.com/vega113 almost there :)

OpenAIServiceImpl.scala isn't formatted properly! OpenAIChatCompletionServiceImpl.scala isn't formatted properly! CreateRunWithFunctionCall.scala isn't formatted properly!

— Reply to this email directly, view it on GitHub https://github.com/cequence-io/openai-scala-client/pull/73#issuecomment-2220558522, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYLEVV7HJSPXFMMXWUHY3ZLU3UVAVCNFSM6AAAAABKCJ4U2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQGU2TQNJSGI . You are receiving this because you were mentioned.Message ID: @.***>