search

cequence-io / ws-client

Core WS Client Infra
https://cequence.io
MIT License
2 stars 3 forks source link

Use akka-stream_3 for Scala 3 #1

Open emmett-rayes opened 2 months ago

emmett-rayes commented 2 months ago

Currently, there is an explicit dependency on "com.typesafe.akka:akka-stream_2.13:2.6.20" for Scala 3 in build.sbt. This dependency transitively includes the 2.13 Versions of the following dependencies as well:

This makes it impossible to use ws-client or any of its dependents like openai-scala-client in projects where one of mentioned transitive dependencies is used in the Scala 3 Version, e.g. akka-stream.

Is there a reason why ws-client can't upgrade to newer versions of akka-stream with Scala 3 support?

peterbanda commented 1 month ago

Hey @emmett-rayes , when the dependencies were set, 2.10.0-RC6 was the latest version compatible with Scala 3.2. I think it can be upgraded now

emmett-rayes commented 1 month ago

Hi @peterbanda, good to know! I created a PR that fixes this issue #2

peterbanda commented 1 month ago

Ok looks good! Thanx for taking care of it. The only question is whether the akka-stream version you set is compatible with play-ahc-ws-standalone and play-ws-standalone-json libs (and with akka-http used for streaming)?