Should FOSUserBundle3 follow current Symfony best practices

cerad / FOSUserBundle3

Symfony 3 specific version of FOSUserBundle

MIT License

3 stars 0 forks source link

Should FOSUserBundle3 follow current Symfony best practices #2

Open ahundiak opened 8 years ago

ahundiak commented 8 years ago

When Symfony 2 was first released there was a set of informal guidelines for developing bundles which the FOSUserBundle followed fairly closely.

We now have an official set of best practices: http://symfony.com/doc/current/best_practices/index.html

Quite a few changes.

So do we go ahead and refactor the code to follow the new guidelines as much as practical while maintaining backwards compatibility? Or pretty much just leave it as is for now?

alexislefebvre commented 8 years ago

While using guidelines is a good thing, may it prevent merges to upstream because it would change a lot of code?

ahundiak commented 8 years ago

The master branch is already following some of the newer practices so I don't really anticipate a big problem with merging if that is the final direction.