search

ceramic-engine / ceramic

Cross-platform 2D framework written in Haxe that can export natively to desktop (windows, mac, linux), mobile (ios, android), web (js + webgl) and to unity projects
MIT License
263 stars 22 forks source link

Rename common `data` variable name in `Entity.hx` #136

Open Jarrio opened 3 months ago

jeremyfa commented 2 months ago

payload or userInfo?

Jarrio commented 2 months ago

customData

On Fri, 13 Sept 2024, 19:28 Jérémy Faivre, @.***> wrote:

payload or userInfo?

— Reply to this email directly, view it on GitHub https://github.com/ceramic-engine/ceramic/issues/136#issuecomment-2349805328, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFWYDJWNUUJEDLNEEKMN4DZWMVEPAVCNFSM6AAAAABMGECNS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZHAYDKMZSHA . You are receiving this because you authored the thread.Message ID: @.***>

jeremyfa commented 2 months ago

I don't like customData, I know that's quite subjective

Jarrio commented 2 months ago

Fair, I just see payload (networking) and userInfo(user data) as still having collision issues. I guess it would be a bit better if we could type them without much hassle

On Fri, 13 Sept 2024, 20:09 Jérémy Faivre, @.***> wrote:

I don't like customData, I know that's quite subjective

— Reply to this email directly, view it on GitHub https://github.com/ceramic-engine/ceramic/issues/136#issuecomment-2349963554, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFWYDIYO5CPDTWJNHGRZL3ZWMZ4ZAVCNFSM6AAAAABMGECNS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZHE3DGNJVGQ . You are receiving this because you authored the thread.Message ID: @.***>