ceramic-engine / ceramic

Cross-platform 2D framework written in Haxe that can export natively to desktop (windows, mac, linux), mobile (ios, android), web (js + webgl) and to unity projects
MIT License
264 stars 22 forks source link

Added several extra colors #79

Closed foreignsasquatch closed 2 years ago

jeremyfa commented 2 years ago

Sorry, I still can’t merge this because you also commited other files that are unrelated (even an image file). Please make another pull request with only the changes in Color.hx.

Also noticed a typo (ORAGNERED instead of ORANGERED)

jeremyfa commented 2 years ago

Also DARKOLIVEGREEEN (with 3 E 😅)

not a bad idea to double check the names

foreignsasquatch commented 2 years ago

Sorry, I still can’t merge this because you also commited other files that are unrelated (even an image file). Please make another pull request with only the changes in Color.hx.

Also noticed a typo (ORAGNERED instead of ORANGERED)

that image was the one in the test image which i unknowingly renamed it was just renamed again

foreignsasquatch commented 2 years ago

Fixed the typo, i do not know how to fix the package.json though

jeremyfa commented 2 years ago

Still can't merge it, because the history includes unrelated commits. To make it clean, you should fork a new branch from the official ceramic and only put the Color.hx changes then submit that branch as a pull request.

If you are uncomfortable doing that on your machine, it's actually pretty easy to do it via Github directly:

I'm closing this current pull request because I won't be able to merge it, but waiting for your clean pull request following the above steps :)

foreignsasquatch commented 2 years ago

👍