ceramicnetwork / js-ceramic

Typescript implementation of the Ceramic protocol
http://ceramic.network
Other
414 stars 127 forks source link

URGENT: Remove @overnightjs/logger or enforce package-lock.json #1980

Closed vaultec81 closed 2 years ago

vaultec81 commented 2 years ago

Describe the bug Recently, the maintainer of the colors npm package has decided to go rogue. Read me here and here The package @overnightjs/logger used in Ceramic depends on colors

To Reproduce

The nodejs code below will demonstrate this issue.

NOTE: you will need to do a fresh install with no package-lock.json or already existing node_modules..


import CeramicHTTP from '@ceramicnetwork/http-client'

const ceramic = new CeramicHTTP('<ceramic API url>')

Screenshots After running the above code

image

And thousands of lines of garbage data being put out.

Ceramic versions As far as I am aware this affects all ceramic versions. Any version that uses @overnightjs/logger or colors npm package directly or indirectly.

I was running Ceramic http client v 1.4.0 but it also happens on latest.

A quick work around is having a package-lock.json, however, new installs will not have this available.

v-stickykeys commented 2 years ago

Have been able to reproduce the issue as well.

v-stickykeys commented 2 years ago

Created a PR and you can use this branch to run js-ceramic without the issue until we create a new release.

oed commented 2 years ago

Thank you for reporting this @vaultec81! I believe the issue should now be addressed. Can you confirm?

oed commented 2 years ago

Separate note: Seems like @overnight/logger has been deprecated: https://github.com/seanpmaxwell/overnight#overnightjs

We should make sure to replace this with something different. @ukstv @stephhuynh18 @stbrody

vaultec81 commented 2 years ago

Thank you for reporting this @vaultec81! I believe the issue should now be addressed. Can you confirm?

Yep! Fixed on my end!

ukstv commented 2 years ago

Separate note: Seems like @overnight/logger has been deprecated: https://github.com/seanpmaxwell/overnight#overnightjs

We should make sure to replace this with something different. @ukstv @stephhuynh18 @stbrody

It has already been replaced with jet-logger by @stephhuynh18 in 2.x

oed commented 2 years ago

Nice :)