fix: unique metadata is not properly typed as a Uint8Array

ceramicnetwork / js-ceramic

Typescript implementation of the Ceramic protocol

http://ceramic.network

Other

414 stars 127 forks source link

fix: unique metadata is not properly typed as a Uint8Array #3166

Closed dbcfd closed 8 months ago

dbcfd commented 8 months ago

This test will fail without this change.

stbrody commented 7 months ago

@dbcfd I'm confused why this PR was opened when we already had another PR with this same change in flight? https://github.com/ceramicnetwork/js-ceramic/pull/3141

I'd still really like to understand how and why we are winding up with data that isn't in the format we are expecting. I'm worried that this approach is papering over the symptoms rather than addressing the real source of the bug - which is whatever is generating data that doesn't have unique typed properly in the first place.

stbrody commented 7 months ago

This test will fail without this change.

is it possible then that the Ceramic rust client isn't constructing/serializing the unique field in the same way as the javascript client does? Seems like that would be a bug in the rust client then.