ceramicnetwork / js-ceramic

Typescript implementation of the Ceramic protocol
http://ceramic.network
Other
414 stars 127 forks source link

chore: make TestUtils.waitForConditionOrTimeout throw on failure #3199

Closed stbrody closed 6 months ago

stbrody commented 6 months ago

Currently it returns false if it fails, which is error prone as it means the test author needs to remember to check the return value or re-check the condition after calling it. Making it throw on error makes the behavior more obvious and harder to mis-use, at the cost of possibly getting less useful error messages in some cases.

linear[bot] commented 6 months ago

CORE-128 make TestUtils.waitForConditionOrTimeout throw on timeout