search

ceramicnetwork / js-ceramic

Typescript implementation of the Ceramic protocol
http://ceramic.network
Other
414 stars 127 forks source link

fix: sleep if loop duration is a special 0 #3238

Closed ukstv closed 3 months ago

linear[bot] commented 3 months ago

AES-45 Weird test failure that ends in OOM

stbrody commented 3 months ago

hmm, can you explain the motivation behind this change? The minLoopDurationMs isn't configurable currently and is hard-coded to 1 minute, so I don't think it could ever be 0 so this new case will never be hit.

ukstv commented 3 months ago

hmm, can you explain the motivation behind this change? The minLoopDurationMs isn't configurable currently and is hard-coded to 1 minute, so I don't think it could ever be 0 so this new case will never be hit.

https://github.com/ceramicnetwork/js-ceramic/blob/develop/packages/stream-tests/src/create-ceramic.ts#L27 Really?

ukstv commented 3 months ago

On a serious note, pinged you on Linear.

stbrody commented 3 months ago

ah whoops, I was only thinking about in production code, not test code. Good catch, makes sense.

ukstv commented 3 months ago

Yahoo!