ceramicnetwork / js-ceramic

Typescript implementation of the Ceramic protocol
http://ceramic.network
Other
414 stars 127 forks source link

js-ceramic configuration should take a flag for the node secret (string or file) #3252

Open 3benbox opened 1 month ago

3benbox commented 1 month ago

Description

Starting the js-ceramic daemon currently requires the node secret in the configuration file. The secret should be accessible from outside the configuration file for better security and easier operations.

Technical Information

Add configurations flags and/or env vars detailing where the node secret can be found.

Something like --node-secret-string=<NODE_SECRET> --node-secret-file-path=<FILE_PATH_TO_NODE_SECRET>

stbrody commented 1 month ago

Sorry @3benbox can you clarify what you mean by the "node secret"? What property from the config file are you referring to?

3benbox commented 1 month ago

Sorry @3benbox can you clarify what you mean by the "node secret"? What property from the config file are you referring to?

The node.privateSeedUrl (also, url?)

https://github.com/ceramicnetwork/js-ceramic/blob/develop/packages/cli/src/ceramic-daemon.ts#L311C9-L311C43