chore: cleanup related to starting/stopping ceramic-one from daemon

dav1do commented 1 month ago

Description

We now call ipfs.stop() for rust ceramic to make sure it gets shutdown when something goes wrong during setup. This required adjusting the override for the remote IPFS client as there is no shutdown endpoint on ceramic-one like kubo.
We now default to a standard (not hidden) folder called ceramic-one in the local directory as the default store-dir.
We now force shutdown ipfs/c1 if we fail to send SIGTERM. The messaging around binary shutdown errors were adjusted as well. The acutal issue re-binding ports was due to ceramic-one shutdown and should be fixed in rust-ceramic #440.

How Has This Been Tested?

Local testing with rust-ceramic #440 and CI.

PR checklist

Before submitting this PR, please make sure:

[x] I have tagged the relevant reviewers and interested parties
[x] I have updated the READMEs of affected packages
[x] I have made corresponding changes to the documentation

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

linear[bot] commented 1 month ago

AES-213 Shutdown bundled ceramic-one when js-ceramic shuts down

dav1do commented 1 month ago

This isn't ready yet, there is a case where the repository can fail to start up which doesn't call shutdown on the binary so it continues running in the background. Need to review some more to figure out how to correct that.

dav1do commented 1 month ago

This isn't ready yet, there is a case where the repository can fail to start up which doesn't call shutdown on the binary so it continues running in the background. Need to review some more to figure out how to correct that.

Should be handled in 490e8b.

ceramicnetwork / js-ceramic