ceramicnetwork / js-ceramic

Typescript implementation of the Ceramic protocol
http://ceramic.network
Other
414 stars 127 forks source link

chore: change ipfs default to remote mode and remove bundled ceramic-one #3261

Closed dav1do closed 1 month ago

dav1do commented 1 month ago

Description

The default IPFS mode is now remote with localhost:5101 (ceramic-one). We no longer support starting the ceramic-one binary automatically in bundled mode outside of tests. It didn't provide a super elegant startup as we don't have a good cross platform install method for node so couldn't guarantee the defaults and it isn't how we want people to run things anyway. It also had some issues stopping, especially when errors occur during start up and rather than rework that handling, we're moving away from the option.

This changes the default config options to remote ceramic one, so it doesn't "just work" if you run node ceramic.js daemon like it would before. If you previously had bundled mode in your config, you will get an error saying it's not supported and you should pass a url.

Note

The local CI still passes as we're starting in bundled mode for the tests, however, the daemon is no longer able to do that so the verifyImage task fails. It will require validating and merging the changes in pipeline-tools first before this is fully green.

How Has This Been Tested?

Ran daemon locally and CI.

PR checklist

Before submitting this PR, please make sure:

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

linear[bot] commented 1 month ago

AES-231: remove-bundled-mode-and-default-to-c1-url-as-localhost5101

edited as I put 230 instead of 231 in the branch name

linear[bot] commented 1 month ago

AES-230 Bug: js-ceramic needs to resubscribe to models on startup

linear[bot] commented 1 month ago

AES-230 Bug: js-ceramic needs to resubscribe to models on startup

linear[bot] commented 1 month ago

AES-230 Bug: js-ceramic needs to resubscribe to models on startup