search

ceramicnetwork / js-dag-jose

Other
46 stars 9 forks source link

Update IPFS codec registration example #20

Open jbouwman opened 3 years ago

jbouwman commented 3 years ago

Update documentation to reflect that versions of js-IPFS greater than 0.40 support direct usage of multiformats codecs.

jbouwman commented 3 years ago

ok_hand nice lgtm aside from the use of 'dag-jose' over dagJose.name as mentioned inline

Done -- thank you for the review. I arrived here after stepping through https://blog.ceramic.network/how-to-store-signed-and-encrypted-data-on-ipfs/ which refers to the legacy codec wrapper. I wonder if there's a way to attach a note there mentioning the change.

rvagg commented 3 years ago

@oed will know. There's been a lot of change in the entire IPLD (and therefore js-ipfs) stack this year but it should have stabilised now so this pattern should be good for the time being.