achingbrain commented 2 years ago

deps: bump @ipld/dag-cbor to 8.0.0

Description

Following on from #28 - update @ipld/dag-cbor to same multiformats version as the rest of the module

How Has This Been Tested?

[x] Unit tests in module pass

Definition of Done

Before submitting this PR, please make sure:

[x] The work addresses the description and outcomes in the issue
[ ] I have added relevant tests for new or updated functionality
[ ] My code follows conventions, is well commented, and easy to understand
[x] My code builds and tests pass without any errors or warnings
[ ] I have tagged the relevant reviewers
[ ] I have updated the READMEs of affected packages
[ ] I have made corresponding changes to the documentation
[ ] The changes have been communicated to interested parties

References:

28

achingbrain commented 2 years ago

cc @ukstv sorry - one more small one

ukstv commented 2 years ago

Okay, going to release a major version soon.

ukstv commented 2 years ago

Hmm, the only change for @ipld/dag-cbor 7 -> 8 is ESM-only publish. We publish js-dag-jose package as ESM-only already. So, from SemVer standpoint it changes nothing for dag-jose end user. I think, patch version makes more sense here.

achingbrain commented 2 years ago

The other thing is that the CID instances in @ipld/dag-cbor 8 come from multiformats 10 which was the upgrade in #28/dag-jose@3.0.0 so a patch to 3.0.1 would make sense as now everything is multiformats 10.

ukstv commented 2 years ago

Sweet! 3.0.1 is released!

ceramicnetwork / js-dag-jose