search

ceramicnetwork / rust-ceramic

Implementation of the Ceramic protocol in Rust
Other
37 stars 10 forks source link

feat: use key value pairs for experimental feature flags #512

Closed stephhuynh18 closed 1 month ago

stephhuynh18 commented 2 months ago

I removed none because I didn't know what to do with it Used https://github.com/ceramicnetwork/rust-ceramic/pull/448#pullrequestreview-2213083696 as reference Can comma separate or set --experimental-feature-flags multiple times

linear[bot] commented 2 months ago

AES-302 Adapt feature flag framework to use key value pairs

stbrody commented 1 month ago

Recapping a conversation from discord: I'd love to eliminate "experimental" feature flags and collapse them into regular feature flags.

my vote would be for a single flag, --feature-flags that can be set multiple times, where each flag is a key value pair. For example: ceramic-one daemon --feature-flags validation=enabled --feature-flags anchoring=delegated

or possibly: ceramic-one daemon --feature-flags validation=enabled,anchoring=delegated

I don't feel strongly on comma separated vs specify the flag multiple times. I lean towards specifying multiple times though as I think it will make it easier to have flags that are themselves lists and need comma separation, without a bunch of nasty escaping logic

stephhuynh18 commented 1 month ago

Closing in favor of aarons suggestion