cerbero90 / query-filters

Laravel package to filter Eloquent model records based on query parameters. Fully inspired by the Laracasts episode https://laracasts.com/series/eloquent-techniques/episodes/4
MIT License
84 stars 15 forks source link

Add support for Laravel 7.0 #8

Closed LorenzoSapora closed 4 years ago

LorenzoSapora commented 4 years ago

Update composer with latest illuminate packages

Ref: #7

LorenzoSapora commented 4 years ago

For some reason the travis tests are trying to run on PHP 5.6. From Laravel 5.5, the package has required PHP7+. So, this failure isn't an issue

LorenzoSapora commented 4 years ago

Ah, I see the issue. You're still attempting to support Laravel 5.4. I think we could branch the current version as 5.4 supported, and move ahead with pure PHP7+ support for Laravel 5.5|7.0+.

cerbero90 commented 4 years ago

Ciao Lorenzo e grazie mille per il tuo aiuto 👍

Unless I'm wrong, it looks like PHP 5.6 is no longer enough to resolve dependencies in the modern composer. Along with the changes in your PR, the file .travis.yml now prevents memory limit when updating the package dependencies. That seems to make Travis happy again.

Grazie ancora e buona giornata 😉