search

cerbo / aws-waf-security-automation

Amazon WAF Security Automation deployment (modular with Terraform)
Apache License 2.0
73 stars 28 forks source link

V2 #2

Closed jasonmcintosh closed 6 years ago

jasonmcintosh commented 6 years ago

Here's initial pull request with fixes. Can work from this :)

ventz commented 6 years ago

@jasonmcintosh For the waflambdafiles - let's do a mix of both the customer name and the random string:

${var.customer}-waflambdafiles-${random_string.lambda_bucket.result}

If you are changing things, mind doing a pull on your copy to remove the zip from the PR so that I can merge it through the web page? (I can do it manually, but it's really convenient through the web)

jasonmcintosh commented 6 years ago

Note still got more testing to do - didn't get a chance tonight to run that, will do so tomorrow ;) Thanks for the merge!!

ventz commented 6 years ago

@jasonmcintosh Great - thanks. PR Merged.