cerc-io / laconicd-deprecated

Read-only mirror of https://git.vdb.to/cerc-io/laconicd-deprecated
https://git.vdb.to/cerc-io/laconicd-deprecated
GNU Lesser General Public License v3.0
6 stars 8 forks source link

wrap typed data for record attributes #70

Closed 0xmuralik closed 1 year ago

0xmuralik commented 1 year ago

Fix for https://github.com/cerc-io/laconic-sdk/issues/8

Description

See https://github.com/cerc-io/laconic-sdk/pull/15


For contributor use:


For admin use:

codecov-commenter commented 1 year ago

Codecov Report

Merging #70 (6eeed3d) into main (75bcf1f) will decrease coverage by 0.10%. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/cerc-io/laconicd/pull/70/graphs/tree.svg?width=650&height=150&src=pr&token=5tWmn7LxfO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/cerc-io/laconicd/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #70 +/- ## ========================================== - Coverage 58.53% 58.43% -0.11% ========================================== Files 142 142 Lines 15615 15644 +29 ========================================== Hits 9141 9141 - Misses 6120 6149 +29 Partials 354 354 ``` | [Impacted Files](https://codecov.io/gh/cerc-io/laconicd/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [ethereum/eip712/eip712.go](https://codecov.io/gh/cerc-io/laconicd/pull/70/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vZWlwNzEyL2VpcDcxMi5nbw==) | `0.00% <0.00%> (ø)` | |
0xmuralik commented 1 year ago

All sdk tests pass and merging this now.