Open dboreham opened 1 year ago
@telackey what's the story here? Did it just work?
It's a multipart answer. The first is that using go-ethereum as an example, I have become convinced that the old stack-orchestrator is not providing any scenario not already covered better by the new stack-orchestrator. In both old_tests.yml and tests.yml, the basic form is to create a testnet, add a TX, see that it is accepted, and then see that some content is in the statediff DB (the exact content is not verified). I do not see an advantage to keeping dual forms of that, and I think it is time to declare the old stack-orchestrator obsolete and simply use the new.
That said, I haven't tested stack-orchestrator specifically inside Gitea yet. It should work fine, in the same way that the statediff tests (which use docker compose
directly) work, but I did not test it properly.
The hiccup (and this can be worked around) is getting the repos just so. Probably the best course is to:
1) Also migrate ipld-eth-db into a test repo, so that the checkout step can work properly. 2) Just symlink the repos instead of using the 'setup-repositories' in stack-orchestrator, because (at this time) that will attempt to checkout from GitHub. 3) Build containers and run.
Alternately, we could provide SO with GitHub credentials and allow it to checkout the repos it needs from GitHub, but it seems like that might be more confusing, since code would be drawn from multiple sources.
e.g. in cerc/go-ethereum