I think your demo site is not working properly

cereallarceny / cra-ssr

[DEPRECATED] Server-side rendering with create-react-app, React Router v4, Helmet, Redux, and Thunk

484 stars 118 forks source link

I think your demo site is not working properly #3

Closed markky21 closed 6 years ago

markky21 commented 6 years ago

I downloaded your repository and launched the application and what comes from the server has an empty html skeleton. I thing it should have not empty #root div at least. The same on the website: https://cra-ssr.herokuapp.com/.

cereallarceny commented 6 years ago

Do you have Javascript enabled? I'm able to load the entire website.

markky21 commented 6 years ago

No, it's not that :) div # root that comes from the server is empty. I think it should not be like this. div # root should contain the rendered html. Unless it was not your goal. Thx for quick answer!

chuck-durst commented 6 years ago

Hi,

Same problem here after having cloned your repo and also in your heroku app.

When looking at the title tag of your HTML markup (from the Chrome dev tools), I have "React App" instead of "Homepage | SSR Website".

Btw everything seems to work just fine when making a test with the Facebook debug tool, I just don't understand how it is actually possible ?

I'm gonna make some tests with a personal project to see if it works too. Thank you for the great work anyway! :)

cereallarceny commented 6 years ago

I now use the following library for server-side rendering: https://github.com/kirill-konshin/create-react-server/

I'll likely make a Medium post on this shortly and deprecate this repository.

shashircciit commented 6 years ago

@cereallarceny hey I am also getting the same issue like @markky21. I am not getting the body data in div # root in your demo project. If you have any solution kindly share with me.