Cut-site databases saved to filesystem are not backwards portable to older Python.

cerebis / qc3C

Reference-free quality assessment for Hi-C sequencing data

GNU Affero General Public License v3.0

12 stars 1 forks source link

Cut-site databases saved to filesystem are not backwards portable to older Python. #46

Open cerebis opened 3 years ago

cerebis commented 3 years ago

The cut-site database is stored to the filesystem using pickle. When doing so, the flag HIGHEST_PROTOCOL is used, but between Python 3.7 and 3.8 a new protocol was added (v5). Therefore files created in Py38 are not readable by Py37 and older.

I should probably specify the opposite flag or pin a protocol used by the oldest supported Python (3.7)

https://github.com/cerebis/qc3C/blob/098f494505c7e9c9d3b6fe2b86623f3d393b8921/qc3C/ligation.py#L407

cerebis commented 3 years ago

This would just be downcast to protocol 4 -- the current default protocol and supported back to Python 3.4.