search

cerebral-legacy / cerebral-module-forms

Form handling for Cerebral
http://cerebral-website.herokuapp.com/documentation/cerebral-module-forms
MIT License
12 stars 5 forks source link

Pr/misc #16

Closed edgesoft closed 8 years ago

edgesoft commented 8 years ago
edgesoft commented 8 years ago

I've created a pull request. Please go thru it when you have the time.

Guria commented 8 years ago

First commit is definetly not a feat, all other seems LGTM

edgesoft commented 8 years ago

Ok, took the same commit as cerebral-view-react

Guria commented 8 years ago

It's a feat for view-react, but here we just update a demo. Take a note that all feat and fix commit will go to release notes

edgesoft commented 8 years ago

Ah, ok! Then rebase again...

edgesoft commented 8 years ago

Ok, I've rebased the feat to chore and added some linting for test that I squashed.

edgesoft commented 8 years ago

Is there a way no to pass defaultValue instead of resetting it?

You can pass all the props that you need but this is made in a fashion to pass all props. We will go thru this later and rebuild the whole demo app and make it nicer and maybe add it to cerebraljs.com/formsdemo

edgesoft commented 8 years ago

Looks like there where a miss on React 15 in cerebral-view-react. Updated it now.

Guria commented 8 years ago

Will check pr later today