search

cerebral-legacy / cerebral-module-forms

Form handling for Cerebral
http://cerebral-website.herokuapp.com/documentation/cerebral-module-forms
MIT License
12 stars 5 forks source link

Merge isValidForm and isValidatingForm #2

Closed edgesoft closed 8 years ago

edgesoft commented 8 years ago

@christianalfoni In the helpers folder isValidForm and isValidatingForm only has one diff on line 12. Maybe we could remove one of them and merge?

edgesoft commented 8 years ago

Or pull out the isValidArray as a function.

christianalfoni commented 8 years ago

That sounds like a good idea :) Let me add my latest contribution here as well. Pushing it now

edgesoft commented 8 years ago

@christianalfoni Just reviewed the code and it is still there. This is not an issue because the code works just fine. Should I close it?

abalmos commented 8 years ago

@edgesoft Leave it open. We need to clean it up at some point