cerebral-legacy / cerebral-module-forms

Form handling for Cerebral
http://cerebral-website.herokuapp.com/documentation/cerebral-module-forms
MIT License
12 stars 5 forks source link

chore: prepare for Cerebral@0.35.x and Cerebral@next #35

Closed edgesoft closed 8 years ago

edgesoft commented 8 years ago
edgesoft commented 8 years ago

@Guria waiting for your LGTM

Guria commented 8 years ago

Now we also have models exposed as 'cerebral/models/mutable' and 'cerebral/models/immutable':

import Model from 'cerebral/models/mutable'
import Model from 'cerebral/models/immutable'
import {mutable as Model} from 'cerebral/models'

could you also split into 2 commits:

chore: prepare for cerebral@0.35.x
feat: remove components reference implementations

BREAKING CHANGE:
React components removed. Examine new demo implementation for reference.
edgesoft commented 8 years ago

@Guria Humm, I don't think it's a breaking change. It's just the demo.

edgesoft commented 8 years ago

@Guria Well you are right. If they used the react wrappers it's a breaking change.

edgesoft commented 8 years ago

@Guria is this ok?

Guria commented 8 years ago

Lgtm.

Guria commented 8 years ago

@edgesoft fixed

edgesoft commented 8 years ago

Thanks @Guria !