search

cerebral-legacy / cerebral-module-router

An opinionated URL change handler for Cerebral
http://cerebral-website.herokuapp.com/documentation/cerebral-module-router
19 stars 4 forks source link

Namespace inputs #16

Closed jeroenverfallie closed 9 years ago

jeroenverfallie commented 9 years ago

Combined with https://github.com/christianalfoni/cerebral/issues/103 this would make the debugger nicer, and the input object in general.

We can argue about params, if they should be contained in a params object, or just on the global input object as they are now.

bfitch commented 9 years ago

Screenshot showing a common example of the router input "pushing" other input values out of view:

screen shot 2015-09-21 at 12 15 32 am

My app specific input {accessToken: 'efdsafeuEREfddfa13rf'} is not visible. :smile:

bfitch commented 9 years ago

I also like the idea @jeroenverfallie mentioned in Gitter about namespacing router inputs. Although it wouldn't help this particular issue, it makes the actions code a little clearer: input.router.params indicates clearly where those values are coming from. Also just keeps the input object a little "cleaner". Just throwing that out there!

christianalfoni commented 9 years ago

Jup, I agree, that seems like the best way to go. In combination with the react-object-inspector it is going to be awesome :)

jeroenverfallie commented 9 years ago

They are now under router. Yay!