search

cerebral-legacy / cerebral-module-router

An opinionated URL change handler for Cerebral
http://cerebral-website.herokuapp.com/documentation/cerebral-module-router
19 stars 4 forks source link

router could break signal chain #37

Closed Guria closed 9 years ago

Guria commented 9 years ago

Let assume developer used url, path, params or query key in input. Chain inputs would be broken once router added to project. Also this keys can't be used as keys for route definitions.

christianalfoni commented 9 years ago

Router now uses "route" property on input. So this is solved?

Guria commented 9 years ago

nope see #41

Guria commented 9 years ago

Issue description contains a link to problem code. Issue resolved in #41 which already part of #40