search

cerebral-legacy / cerebral-module-router

An opinionated URL change handler for Cerebral
http://cerebral-website.herokuapp.com/documentation/cerebral-module-router
19 stars 4 forks source link

make URLON queries enabled by default #62

Open Guria opened 8 years ago

Guria commented 8 years ago

Please dump your votes and objections here.

christianalfoni commented 8 years ago

I agree, should be default

abalmos commented 8 years ago

I am impartial. URLON by default seems fine to me as long as it can easily be turned off.

aesprice commented 8 years ago

URLON is fine, but it should definitely be optional. I'm working on converting an existing app to cerebral-router and we don't want to have to change the URLs, which could wreak havoc on our existing userbase. URLON seems like a good system, but not a necessary one for all applications and use cases.

Guria commented 8 years ago

@aesprice would it fit you if it enabled by default, but can be disabled?

aesprice commented 8 years ago

@Guria If disabling it is simple and straightforward, yes. Like, a simple flag in the Router options or the mapper options would be all I need:

router: Router({
    '/': 'home.opened',
    '/messages': 'messages.opened'
  }, {
    urlon: false,
    mapper: {query: true}
  })