search

cerebral-legacy / cerebral-view-react

React View layer package for Cerebral
16 stars 9 forks source link

React 15.2.0 throws errors for basic elements being passed props #58

Closed NervosaX closed 8 years ago

NervosaX commented 8 years ago

The new react whitelists the allowed props to be passed to elements (a, div, span, etc.). Anything else throws a scary warning.

See https://gist.github.com/jimfb/d99e0678e9da715ccf6454961ef04d1b for the react error message

Examples are: https://github.com/cerebral/cerebral-view-react/blob/master/src/link.js#L63 Link being passed props it can't handle (params, signal)

https://github.com/cerebral/cerebral-view-react/blob/master/src/container.js#L18 Container being passed controller

etc.

christianalfoni commented 8 years ago

This has been fixed in the state-tree branch of the view. I suppose we can bring the fix into current version as well. You have time @Guria , since you made the other fix? It is just returning the children instead of creating that element thingy.