cerebral-legacy / discussion

0 stars 0 forks source link

linting tool #1

Closed Guria closed 8 years ago

Guria commented 8 years ago

We need final decission on linting tools / rules across oraganisation repositories. I have suggested zero-configuration variant standard but it includes no semicolons rule (authors sais that it's fine). Another suggestion was to use semistandard(standard but with semicolons) as alternative. Third option could be shareable config package for eslint.

cc @cerebral/collaborators and others with reasonable opinions.

garth commented 8 years ago

I think that an eslint configuration that can be shared across all cerebral projects would be a good idea.

// example package.json
{
  "scripts": {
    "lint": "eslint --config node_modules/cerebral-lint/.eslintrc ."
  }
}
christianalfoni commented 8 years ago

Yeah, I like @garth suggestion. Gives most flexibility. When it comes to actual rules I do not have any opinion. The codebase is not really that huge, so not much work conforming to anything really. But we might have some fun linting discussions. Maybe we could have like "beer lint-pong"? One team wants one rule and somebody an other and we play beer pong on it? :-)

It really just not matter. We just have to choose one. I suggest we hook in the rules from "standard" and @garth can review with suggested changes. Then we just tell people: "Meet up at that time, we will vote". Those who does not meet, wont have a say.

Later we can have "beer lint-pong" competition at cerebral-conf, for a second review ;-)

Guria commented 8 years ago

I also don't have opinion on rules. I can adapt to any. I've suggested standard because met some notable count of projects using it and was excited not to use custom rule set but just one command. So we have easy to setup vs comfort with editors.

christianalfoni commented 8 years ago

You know, I think the person making the effort on bringing linting into the projects should decide. If you want to make that effort @Guria, you make the choice. As I think we all agree, we want linting, the rules does not matter... it is the consistency we want :-)

christianalfoni commented 8 years ago

I am extremely happy with standards... or anything else ;-)

garth commented 8 years ago

Are there any stats on standard and semi standard usage?

Guria commented 8 years ago

Only npm's one I think.

Guria commented 8 years ago

BTW standard has plenty plugins for editors

garth commented 8 years ago

yes, I tried some editor plugins. I guess I need to switch from sublime to atom, just that atom is so amazingly slow.

So we are going with standard?

Guria commented 8 years ago

I suppose. If there is no any blocker.

Guria commented 8 years ago

https://github.com/cerebral/discussion/wiki/Linting